Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Misleading labels in Prune Messages #18006

Merged
merged 3 commits into from
Jun 30, 2020
Merged

[FIX] Misleading labels in Prune Messages #18006

merged 3 commits into from
Jun 30, 2020

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jun 22, 2020 •
edited
Loading

Proposed changes

Changed Do not exclude and Exclude to Do not prune for message pruning. Changed the keys for the settings too.

Issue(s)

Closes #17583

How to test or reproduce

Screenshots

Before:
image

After:
image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@sampaiodiego sampaiodiego added this to the 3.5.0 milestone Jun 22, 2020
ggazzo
ggazzo previously approved these changes Jun 22, 2020
View reviewed changes
mtmr0x
mtmr0x previously approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@mtmr0x mtmr0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dudizilla dudizilla dismissed stale reviews from mtmr0x and ggazzo via adb97b7 June 30, 2020 22:52
@ggazzo ggazzo changed the base branch from develop to 2.1 June 30, 2020 23:00
@ggazzo ggazzo changed the base branch from 2.1 to develop June 30, 2020 23:00
@ggazzo ggazzo force-pushed the fix/prune_discussions branch from adb97b7 to e4c0d5b Compare June 30, 2020 23:08
@ggazzo ggazzo merged commit f148fa4 into develop Jun 30, 2020
@ggazzo ggazzo deleted the fix/prune_discussions branch June 30, 2020 23:36
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@mtmr0x mtmr0x mtmr0x left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

misbehaving of "do not exclude discussion messages" option in prune room
4 participants
@gabriellsh @ggazzo @mtmr0x @sampaiodiego